Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update Cocoa SDK to v8.34.0 #4026

Merged
merged 1 commit into from
Aug 16, 2024
Merged

chore(deps): update Cocoa SDK to v8.34.0 #4026

merged 1 commit into from
Aug 16, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Bumps scripts/update-cocoa.sh from 8.33.0 to 8.34.0.

Auto-generated by a dependency updater.

Changelog

8.34.0

Features

  • Pause replay in session mode when offline (#4264)
  • Add replay quality option for Objective-C (#4267)

Fixes

  • Session replay not redacting buttons and other non UILabel texts (#4277)
  • Rarely reporting too long frame delays (#4278) by fixing a race condition in the frames tracking logic.
  • Crash deserializing empty envelope length>0 (#4281]
  • Guard dereferencing of stack frame pointer in SentryBacktrace (#4268)

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Aug 15, 2024
@github-actions GitHub Actions
Copy link
Contributor Author

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.73 ms 1231.37 ms 11.64 ms
Size 2.36 MiB 3.08 MiB 731.86 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms
e2b64fe+dirty 1232.22 ms 1255.20 ms 22.98 ms
9433f35+dirty 1246.94 ms 1271.45 ms 24.52 ms
4a6664f+dirty 1209.49 ms 1208.63 ms -0.86 ms
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms
dadc233+dirty 1223.20 ms 1236.88 ms 13.68 ms
f06c879+dirty 1252.64 ms 1259.66 ms 7.02 ms
5a22220+dirty 1209.49 ms 1220.94 ms 11.45 ms
3853f43+dirty 1221.82 ms 1242.64 ms 20.82 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms

App size

Revision Plain With Sentry Diff
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB
e2b64fe+dirty 2.36 MiB 2.85 MiB 495.80 KiB
9433f35+dirty 2.36 MiB 2.85 MiB 499.80 KiB
4a6664f+dirty 2.36 MiB 3.04 MiB 696.39 KiB
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB
dadc233+dirty 2.36 MiB 2.84 MiB 486.85 KiB
f06c879+dirty 2.36 MiB 2.88 MiB 530.42 KiB
5a22220+dirty 2.36 MiB 2.92 MiB 570.21 KiB
3853f43+dirty 2.36 MiB 2.85 MiB 499.81 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
6a29e9e+dirty 1219.98 ms 1223.66 ms 3.68 ms

App size

Revision Plain With Sentry Diff
6a29e9e+dirty 2.36 MiB 3.04 MiB 698.34 KiB

@github-actions GitHub Actions
Copy link
Contributor Author

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1238.04 ms 1239.90 ms 1.85 ms
Size 2.92 MiB 3.64 MiB 738.37 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
86d6d2c+dirty 1291.62 ms 1296.80 ms 5.18 ms
e2b64fe+dirty 1285.78 ms 1297.56 ms 11.78 ms
9433f35+dirty 1232.24 ms 1232.74 ms 0.50 ms
4a6664f+dirty 1218.77 ms 1221.07 ms 2.30 ms
80b2ce3+dirty 1245.12 ms 1262.04 ms 16.92 ms
dadc233+dirty 1266.52 ms 1282.55 ms 16.03 ms
f06c879+dirty 1285.14 ms 1285.86 ms 0.72 ms
5a22220+dirty 1246.18 ms 1249.61 ms 3.43 ms
3853f43+dirty 1271.74 ms 1278.04 ms 6.30 ms
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms

App size

Revision Plain With Sentry Diff
86d6d2c+dirty 2.92 MiB 3.37 MiB 464.31 KiB
e2b64fe+dirty 2.92 MiB 3.41 MiB 499.97 KiB
9433f35+dirty 2.92 MiB 3.41 MiB 503.55 KiB
4a6664f+dirty 2.92 MiB 3.60 MiB 702.09 KiB
80b2ce3+dirty 2.92 MiB 3.40 MiB 492.75 KiB
dadc233+dirty 2.92 MiB 3.40 MiB 492.53 KiB
f06c879+dirty 2.92 MiB 3.44 MiB 533.24 KiB
5a22220+dirty 2.92 MiB 3.48 MiB 575.81 KiB
3853f43+dirty 2.92 MiB 3.41 MiB 503.54 KiB
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
6a29e9e+dirty 1233.85 ms 1227.88 ms -5.98 ms

App size

Revision Plain With Sentry Diff
6a29e9e+dirty 2.92 MiB 3.61 MiB 705.03 KiB

@krystofwoldrich krystofwoldrich enabled auto-merge (squash) August 16, 2024 10:34
@krystofwoldrich krystofwoldrich merged commit 677106a into main Aug 16, 2024
55 of 58 checks passed
@krystofwoldrich krystofwoldrich deleted the deps/scripts/update-cocoa.sh branch August 16, 2024 10:34
This was referenced Sep 17, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @web-flow